This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Device manager - parse user agent for device information #9352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
September 23, 2022 18:00
* add device selection that does nothing * multi select and sign out of sessions * test multiple selection * fix type after rebase * select all sessions
kerryarchibald
added
the
T-Task
kerryarchibald
requested review from
germain-gg,
turt2live and
t3chguy
and removed request for
a team
kerryarchibald
commented
Oct 5, 2022
| }); | ||
|
|
||
| /* eslint-disable max-len */ | ||
| const ANDROID_UA = [ |
There was a problem hiding this comment.
test data taken from android test suite https://github.com/vector-im/element-android/pull/7247/files
3 tasks
turt2live
approved these changes
Oct 5, 2022
Comment on lines
+84
to
+85
| const concatenateNameAndVersion = (name?: string, version?: string): string | undefined => | ||
| name && [name, version].filter(Boolean).join(' '); |
There was a problem hiding this comment.
Suggested change
| const concatenateNameAndVersion = (name?: string, version?: string): string | undefined => | |
| name && [name, version].filter(Boolean).join(' '); | |
| const concatenateNameAndVersion = (name?: string, version?: string): string | undefined => { | |
| return name && [name, version].filter(Boolean).join(' '); | |
| }; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.