Expose QR login related structs and methods #118
Conversation
poljar
force-pushed
the
poljar/qr-login-pr
branch
2 times, most recently
from
09f02f3 to
706e913
Compare
| #[derive(Clone)] | ||
| #[wasm_bindgen] | ||
| pub struct EstablishedEcies { | ||
| inner: Arc<Mutex<ecies::EstablishedEcies>>, |
There was a problem hiding this comment.
Out of curiosity, are the arc/mutex needed here, since this is wasm and in theory mono-threaded? (unless the consumer is making use of shared array buffers)
There was a problem hiding this comment.
AFAIR yes, leaving them out did not work. On WASM they will be compiled into a no-op, but the Rust compiler complains about... Err I forgot when/where it complained.
| const bundle = await firstMachine.exportSecretsBundle(); | ||
|
|
||
| const alice = new Ecies(); | ||
| const bob = new Ecies(); |
There was a problem hiding this comment.
is it really a bob or rather an alice2?
There was a problem hiding this comment.
It's Alice's second device called Bob.
poljar
force-pushed
the
poljar/qr-login-pr
branch
from
94020b6 to
86f43b7
Compare
poljar
force-pushed
the
poljar/qr-login-pr
branch
from
86f43b7 to
c699380
Compare
| /// Create new [`QrCodeData`] from a given public key, a rendezvous URL and, | ||
| /// optionally, a homeserver URL. | ||
| /// | ||
| /// If a homeserver URL is given, then the [`QrCodeData`] mode will be | ||
| /// [`QrCodeMode::Reciprocate`], i.e. the QR code will contain data for the | ||
| /// existing device to display the QR code. | ||
| /// | ||
| /// If no homeserver is given, the [`QrCodeData`] mode will be | ||
| /// [`QrCodeMode::Login`], i.e. the QR code will contain data for the | ||
| /// new device to display the QR code. |
There was a problem hiding this comment.
please bear in mind that [`QrCodeData`] doesn't work in the documentation generated by wasm_bindgen: see https://matrix-org.github.io/matrix-rust-sdk-crypto-wasm/classes/QrCodeData.html#constructor.
You need to use tsdoc-style {@link ... } links.
There was a problem hiding this comment.
I changed the style in: 2c9bd6f.
| } else { | ||
| None | ||
| } | ||
| } |
There was a problem hiding this comment.
When we're adding new methods to the WASM bindings, please can we use #[wasm_bindgen(js_name)] to give them camelCase names, to be consistent with the rest of the bindings?
This PR depends on #116 and #117 so opening it as a draft. It adds all the functionality necessary to make QR code login work in the js-sdk.
A review commit by commit is recommended.