Skip to content

test: reenable the unread count test in code coverage #3044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Jan 22, 2024

Let's see if the test correctly passes, now that all the racy behaviors should have been fixed with #2978.

Fixes #2963.

@bnjbvr bnjbvr requested a review from a team as a code owner January 22, 2024 10:22
@bnjbvr bnjbvr requested review from Hywan and removed request for a team January 22, 2024 10:22
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b680c50) 83.63% compared to head (0729dfe) 83.68%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3044      +/-   ##
==========================================
+ Coverage   83.63%   83.68%   +0.05%     
==========================================
  Files         222      222              
  Lines       23290    23290              
==========================================
+ Hits        19478    19490      +12     
+ Misses       3812     3800      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bnjbvr
Copy link
Member Author

bnjbvr commented Jan 22, 2024

Turns out the real reason why the test wasn't passing was the same root cause as #3031. The client's room member information was missing, meaning we couldn't compute a push context, so we couldn't compute notifications/mentions either. Fortunately, the fix is simple here too. (I don't think this requires another round of review, but wanted to pinpoint the actual fix).

@bnjbvr bnjbvr enabled auto-merge (squash) January 22, 2024 12:36
@bnjbvr bnjbvr merged commit 76cd7ab into main Jan 22, 2024
@bnjbvr bnjbvr deleted the reinclude-readreceipt-test-tarpaulin branch January 22, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve client-side read receipt support
2 participants