Skip to content

FFI: Allow restoring an existing session with SSS enabled. #3723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions bindings/matrix-sdk-ffi/src/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -388,11 +388,13 @@ impl Client {

self.restore_session_inner(auth_session).await?;

if let Some(sliding_sync_proxy) = sliding_sync_proxy {
let sliding_sync_proxy = Url::parse(&sliding_sync_proxy)
.map_err(|error| ClientError::Generic { msg: error.to_string() })?;
if !self.inner.is_simplified_sliding_sync_enabled() {
if let Some(sliding_sync_proxy) = sliding_sync_proxy {
let sliding_sync_proxy = Url::parse(&sliding_sync_proxy)
.map_err(|error| ClientError::Generic { msg: error.to_string() })?;

self.inner.set_sliding_sync_proxy(Some(sliding_sync_proxy));
self.inner.set_sliding_sync_proxy(Some(sliding_sync_proxy));
}
}

Ok(())
Expand Down
6 changes: 4 additions & 2 deletions bindings/matrix-sdk-ffi/src/client_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -530,8 +530,10 @@ impl ClientBuilder {
// `Some(_)` value in `builder.sliding_sync_proxy`. That's really important: It
// might not break an existing app session, but it is likely to break a new
// session, which not immediate to detect if there is no test.
if let Some(sliding_sync_proxy) = builder.sliding_sync_proxy {
sdk_client.set_sliding_sync_proxy(Some(Url::parse(&sliding_sync_proxy)?));
if !builder.is_simplified_sliding_sync_enabled {
if let Some(sliding_sync_proxy) = builder.sliding_sync_proxy {
sdk_client.set_sliding_sync_proxy(Some(Url::parse(&sliding_sync_proxy)?));
}
}

Ok(Arc::new(
Expand Down
2 changes: 1 addition & 1 deletion crates/matrix-sdk/src/client/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ impl Client {

/// Check whether Simplified MSC3575 must be used.
#[cfg(feature = "experimental-sliding-sync")]
pub(crate) fn is_simplified_sliding_sync_enabled(&self) -> bool {
pub fn is_simplified_sliding_sync_enabled(&self) -> bool {
self.inner.is_simplified_sliding_sync_enabled
}

Expand Down
Loading