Invites room summary fallback #4780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanceriu
requested review from
andybalaam and
bnjbvr
and removed request for
a team and
andybalaam
…nt data if fetching the preview fails - relates to element-hq/element-x-ios/issues/3713 - this will allow us to interact with them even if the given homeserver doesn't have MSC3266 enabled
…ds as those should be retrieved through the room preview
stefanceriu
force-pushed
the
stefan/invitesRoomSummaryFallback
branch
from
9168936 to
abe8338
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4780 +/- ##
==========================================
+ Coverage 86.34% 86.36% +0.01%
==========================================
Files 291 291
Lines 34233 34245 +12
==========================================
+ Hits 29560 29574 +14
+ Misses 4673 4671 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- we're doing this as an extra layer of protection against spam attacks.
stefanceriu
force-pushed
the
stefan/invitesRoomSummaryFallback
branch
from
afc5096 to
ca025f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a fallback mechanism for dealing with invites when the room summary API MSC3266 isn't enabled on the homeserver.
It does so by trying to use whatever data the client has cached about the room, and even though it won't contain a lot of information, it will still provide an usable instance which can be used to accept/decline the invite and partially populate the join room screen (in EX).
It also deals away with the now unnecessary
invited_roomandinviterand expose a new client one for fetching arbitrary rooms based on their identifier.