crypto: encrypt, upload and share keys for room history #4864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/history_sharing/upload_bundle
branch
3 times, most recently
from
41d75d1 to
ea0b176
Compare
richvdh
force-pushed
the
rav/history_sharing/upload_bundle
branch
2 times, most recently
from
f93d4a6 to
3149616
Compare
richvdh
force-pushed
the
rav/history_sharing/upload_bundle
branch
from
3149616 to
b2a6840
Compare
The next step in our work on sharing encrypted room history. Add a method to `matrix_sdk::room::Room` which will upload an encrypted key bundle.
richvdh
force-pushed
the
rav/history_sharing/upload_bundle
branch
2 times, most recently
from
dbba10f to
211b9ad
Compare
For each device belonging to the user, encrypt and send to-device messages containing the bundle data
This is only a partial test, since we haven't yet implemented the receiver side of the history-sharing messages.
richvdh
force-pushed
the
rav/history_sharing/upload_bundle
branch
from
211b9ad to
7cb525f
Compare
richvdh
commented
Apr 9, 2025
| @@ -178,9 +179,17 @@ impl<'a> IntoFuture for ShareRoomHistory<'a> { | |||
| "Uploaded encrypted key blob" | |||
| ); | |||
|
|
|||
| // 3. Send to-device messages to the recipient to share the keys. | |||
| // TODO | |||
| // 3. Establish Olm seeions with all of the recipient's devices | |||
There was a problem hiding this comment.
Suggested change
| // 3. Establish Olm seeions with all of the recipient's devices | |
| // 3. Establish Olm sessions with all of the recipient's devices. |
richvdh
force-pushed
the
rav/history_sharing/upload_bundle
branch
from
e5150ec to
632e1b6
Compare
richvdh
force-pushed
the
rav/history_sharing/upload_bundle
branch
from
632e1b6 to
e963311
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4864 +/- ##
==========================================
- Coverage 85.80% 85.79% -0.01%
==========================================
Files 314 314
Lines 35739 35572 -167
==========================================
- Hits 30666 30520 -146
+ Misses 5073 5052 -21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next step of our plan to share room history (element-hq/element-meta#39). This PR adds the functionality to:
Fixes: #4505