chore(cargo): Update rand to 0.9, and getrandom to 0.3.2
#4885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
added a commit
to Hywan/matrix-rust-sdk
that referenced
this pull request
Apr 4, 2025
|
I'm afraid that this will have to wait for matrix-org/vodozemac#206 and its deps. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4885 +/- ##
==========================================
- Coverage 85.82% 85.81% -0.02%
==========================================
Files 299 299
Lines 35233 35235 +2
==========================================
- Hits 30239 30236 -3
- Misses 4994 4999 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This patch updates `rand` to 0.9. It brings several nice advantages: - it is compatible with the new Rust edition 2024, - it simplifies several signatures since `try_fill` is replaced by `fill`, there is no failure.
This patch deduplicates `getrandom` where it was present in 2 versions. It also updates `getrandom` to 0.3.2.
|
Why?
|
Hywan
changed the title
rand to 0.9rand to 0.9, and getrandom to 0.3.2
|
We have 2 versions of
We have to move many crates… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates
randto 0.9. It brings several nice advantages:try_fillis replaced byfill, there is no failure, thus removing manyunwraps!This patch also updates
getrandomto 0.3.2 and improvestesting with Wasm and
getrandom.Based on chore(cargo): Updateeyeballandimbl#4884