-
Notifications
You must be signed in to change notification settings - Fork 291
feat(ui): New Room List filter: deduplicate_versions
#5084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): New Room List filter: deduplicate_versions
#5084
Conversation
This patch makes the `SuccessorRoom` and `PredecessorRoom` types public.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5084 +/- ##
==========================================
- Coverage 85.83% 85.82% -0.01%
==========================================
Files 333 334 +1
Lines 36158 36175 +17
==========================================
+ Hits 31035 31047 +12
- Misses 5123 5128 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ef68e88
to
d588b09
Compare
Do you mean
? |
No I don't mean that. When a room is left, invited, banned or knocked, we don't see what's happening here, so we don't know if the room is tombstoned or not. Consequently, we consider this is the active version of the room. Those are cases are edge-cases to be honest. |
OK your right, I was thinking of the api to return the room list to the application, but this is something else here. |
crates/matrix-sdk-ui/src/room_list_service/filters/deduplicate_versions.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice 👍
This patch adds the new `deduplicate_versions`. This new filter will filter out room versions that are outdated. Only the “active” versions are kept. A room version is considered active if and only if: * the room is joined and has no successor, * the room is joined and has a successor room that is invited or knocked, * the room is left, invited, banned or knocked. All other rooms are filtered out.
d588b09
to
0e7836e
Compare
This patch adds the new
deduplicate_versions
. This new filter will filter out room versions that are outdated. Only the “active” versions are kept.A room version is considered active if and only if:
All other rooms are filtered out.