Skip to content

Add a stable flag to MSC3916 #4180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

deepbluev7
Copy link
Contributor

In conversation with several client and homeserver developers it has come up that the current schedule for rolling out authenticated media is hard for them to follow if they have to support all of 1.11 at once.

I think the value of authenticated media is high enough to warrant a stable flag to encourage a faster rollout of authenticated media. This allows servers to support authenticated media without supporting all of 1.11 already and the additional burden on client developers is minimal.

This flag is already in use by serveral implementations:

@deepbluev7 deepbluev7 force-pushed the nico/auth-media-stable-endpoint branch from e6d4ead to 109e04d Compare August 24, 2024 11:39
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to the idea in principle, though as I've said elsewhere we should be wary of letting this set a precedent.

In conversation with several client and homeserver developers it has
come up that the current schedule for rolling out authenticated media is
hard for them to follow if they have to support all of 1.11 at once.

I think the value of authenticated media is high enough to warrant a
stable flag to encourage a faster rollout of authenticated media. This
allows servers to support authenticated media without supporting all of
1.11 already and the additional burden on client developers is minimal.

This flag is already in use by serveral implementations:

- neilalexander/harmony@51b5c98
- famedly/matrix-dart-sdk@2dce08b

Signed-off-by: Nicolas Werner <[email protected]>
@deepbluev7 deepbluev7 force-pushed the nico/auth-media-stable-endpoint branch from 109e04d to d8bce00 Compare August 24, 2024 12:53
@deepbluev7
Copy link
Contributor Author

About setting a precedent, we already have stable flags specified in the README: https://github.com/matrix-org/matrix-spec-proposals?tab=readme-ov-file#when-can-i-use-stable-identifiers

While this is adding such flags after the MSC was merged, so not just to bridge the gap between spec releases, I think in this specific case it is important to make a quick rollout of authenticated media possible. Otherwise we will be fragmenting the ecosystem much more imo OR homeservers will have to violate the spec by advertising support for 1.11 without complete support. I think neither of those options is attractive and having a "stable" flag for a while is the least problematic, but if anybody has a better suggestion, I am happy to yield to such a proposal. And if in the future this change is seen as a problematic precedent, I think we can have an MSC about how such problems should be handled in the future, which would overrule any precedent set by this.

@turt2live turt2live self-requested a review August 24, 2024 14:04
@richvdh richvdh merged commit 3b71085 into matrix-org:main Aug 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants