Allow modal widget buttons to be disabled when the modal opens #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think @turt2live is best placed to review this, because it likely means updating / extending the related MSC as well. |
turt2live
approved these changes
Jun 23, 2021
|
@skolmer I believe we'll also need signoff on this change in order to incorporate it. Should be as easy as leaving a comment on here, or editing the PR description to have the following template: Feel free to reach out to me if you have any questions. (I've also updated the MSC to incorporate this) |
|
Thanks for updating the MSC @turt2live |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change that would allow us to initialize modal widget buttons as disabled.
Related PR: matrix-org/matrix-react-sdk#6178
Signed-off-by: Steffen Kolmer [email protected]