Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Add missing type hints to synapse.app. #11287

Merged
merged 13 commits into from
Nov 10, 2021
Merged

Add missing type hints to synapse.app. #11287

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
21cbedd
Add type hints to synapse.app.phone_stats_home.
clokep Oct 26, 2021
b68f6a3
Remove broken profiling code.
clokep Oct 26, 2021
0a851f8
Remove passing files from ignore list.
clokep Nov 9, 2021
215e5b5
Add type hints to admin_cmd.
clokep Nov 9, 2021
cdaac71
Consistently require Resource, not IResource.
clokep Nov 9, 2021
1a2e707
Add type hints to generic_worker.
clokep Nov 9, 2021
a2c8921
Add type hints to homeserver.
clokep Oct 26, 2021
70384c7
Add type hints to _base.
clokep Nov 9, 2021
8c8c4f9
Add type hints to app.__init__.
clokep Nov 9, 2021
f536908
Newsfragment
clokep Nov 9, 2021
0d8455f
Add back NoReturn values.
clokep Nov 10, 2021
69dce52
Use casts for reactors (instead of ignoring or asserting).
clokep Nov 10, 2021
0533b22
Merge remote-tracking branch 'origin/develop' into clokep/app-types
clokep Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions synapse/app/homeserver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,30 +413,6 @@ def format_config_error(e: ConfigError) -> Iterator[str]:


def run(hs: HomeServer):
PROFILE_SYNAPSE = False
if PROFILE_SYNAPSE:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this broken, sorry?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code doesn't work:

type object 'ThreadPool' has no attribute '_worker'

It also doesn't have anyway to enable it without modifying code, so I figure this seems less than useful. I believe that cProfile has too much overhead for actually running synapse, but 🤷 I can attempt to get it to work if you'd like.


def profile(func):
from cProfile import Profile
from threading import current_thread

def profiled(*args, **kargs):
profile = Profile()
profile.enable()
func(*args, **kargs)
profile.disable()
ident = current_thread().ident
profile.dump_stats(
"/tmp/%s.%s.%i.pstat" % (hs.hostname, func.__name__, ident)
)

return profiled

from twisted.python.threadpool import ThreadPool

ThreadPool._worker = profile(ThreadPool._worker)
reactor.run = profile(reactor.run)

_base.start_reactor(
"synapse-homeserver",
soft_file_limit=hs.config.server.soft_file_limit,
Expand Down