Skip to content

Add linting #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JQrdan opened this issue Jun 2, 2020 · 1 comment · Fixed by #9
Closed

Add linting #6

JQrdan opened this issue Jun 2, 2020 · 1 comment · Fixed by #9
Assignees
@JQrdan

Comments

@JQrdan
Copy link

JQrdan commented Jun 2, 2020

Discuss which rules we want (code)
Commit messages
Do we want Husky etc?
@JQrdan JQrdan self-assigned this Jun 2, 2020
JQrdan pushed a commit that referenced this issue Jun 2, 2020
feat: add linting rules
0ad7225 
Contributes to: #6

Signed-off-by: Jordan <[email protected]>
JQrdan pushed a commit that referenced this issue Jun 2, 2020
feat: add code and commit linting
adef220 
Contributes to: #6

Signed-off-by: Jordan <[email protected]>
JQrdan pushed a commit that referenced this issue Jun 2, 2020
feat: add code and commit linting
2b33643 
Contributes to: #6

Signed-off-by: Jordan <[email protected]>
JQrdan pushed a commit that referenced this issue Jun 2, 2020
docs: update contributing guide
efaddf8 
Contributes to: #6

Signed-off-by: Jordan <[email protected]>
@JQrdan
Copy link
Author

JQrdan commented Jun 2, 2020

Commit linting is currently non-ideal as we cannot check for a signed-off by field.

Issue raised here: conventional-changelog/commitlint#1809

JQrdan pushed a commit that referenced this issue Jun 3, 2020
docs: remove design link in feature template
c2bce7c 
Contributes to: #6

Signed-off-by: Jordan <[email protected]>
@JQrdan JQrdan linked a pull request Jun 3, 2020 that will close this issue
Lintings #9
Merged
JQrdan pushed a commit that referenced this issue Jun 3, 2020
feat: add code and commit linting
403b0a5 
Contributes to: #6

Signed-off-by: Jordan <[email protected]>
JQrdan pushed a commit that referenced this issue Jun 3, 2020
docs: update contributing guide
dc206de 
Contributes to: #6

Signed-off-by: Jordan <[email protected]>
JQrdan pushed a commit that referenced this issue Jun 3, 2020
docs: remove design link in feature template
99049d8 
Contributes to: #6

Signed-off-by: Jordan <[email protected]>
matthew-chirgwin pushed a commit that referenced this issue Jun 3, 2020
feat: Add linting (#9)
99b7722 
  - Adds code linting with eslint
  - Adds prettier for auto code format
  - Add commitlint for commit linting 
  - Adds husky for auto linting, prettier, and commit linting on commit
  - Add templates for issues and pull requests

Contributes to: #6

Signed-off-by: Jordan <[email protected]>
matthew-chirgwin pushed a commit that referenced this issue Jun 26, 2020
@matthew-chirgwin
feat: Add linting (#9)
3943e6a 
  - Adds code linting with eslint
  - Adds prettier for auto code format
  - Add commitlint for commit linting 
  - Adds husky for auto linting, prettier, and commit linting on commit
  - Add templates for issues and pull requests

Contributes to: #6

Signed-off-by: Jordan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JQrdan JQrdan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lintings matthew-chirgwin/kafka-java-vertx-starter
1 participant
@JQrdan