-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize bridge rooms into a space #413
Conversation
You can add |
@sumnerevans this feature is not complete.
Could you review the code and share your feedback? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Generally seems pretty good. Looks like there's some TODOs still around config that also need to be addressed.
portal.go
Outdated
func (portal *Portal) addToSpace(spaceID id.RoomID, portalID id.RoomID) { | ||
|
||
parentSpaceContent := make(map[string]interface{}) | ||
parentSpaceContent["via"] = []string{"matrix.wounn.xyz"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be the bridge's homeserver URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. Should have fixed that when this commit was pushed.
From MSC 1772
via
key which gives a list of candidate servers that can be used to join the room
It means these servers will be used to bootstrap the join request (permalink to comment in spaces:riot.ovh)
The bridge's homeserver should be part of via - yes. Should we include the user's homeserver too if it is different from the bridge's homeserver? @HelderFSFerreira we'll try testing this on a federated instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the bridge home server as the value of the via.
Are we sure that we want to have the client's home server in there too?
As far as how to add to the config, I'd just do something like: I think it may make sense to something like what the |
So migration will be
New users can just set
|
Co-authored-by: clmnin <[email protected]>
Co-authored-by: clmnin <[email protected]>
Co-authored-by: clmnin <[email protected]>
92e1c66
to
0a8bd77
Compare
Merged in 3a9b3ab |
Features:
To do: