fixes npm citgm tests that pull source code using repository #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodejs/citgm#1092
an old repo link like github.com/maxogden/binary-split will redirect to the new one, but for some reason the old
codeload.github.comlink won't redirect to the new repo.This is because the source code for binary-split is being fetched from (which is 404):
https://codeload.github.com/maxogden/binary-split/tar.gz/47044d430f5973380bfd4ef3d179f9d5f3eb54b4
we use the repo link to fetch the source when we run CITGM https://github.com/npm/cli/blob/latest/.github/workflows/node-integration.yml#L326