don't crash on socket error #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -83,6 +83,8 @@ function WebSocketStream(target, protocols, options) { | |||
| socket.onerror = onerror | |||
| socket.onmessage = onmessage | |||
|
|
|||
| proxy.on('error', function(){}) | |||
There was a problem hiding this comment.
Ignore errors? It can lead to even more long debugging then you have had.
There was a problem hiding this comment.
It seems we have two options here: Ignore unhandled errors or have unhandled errors lead to crashes. My first pull request was to document how to handle errors so you don't have crashes and I was asked to instead fix the issue. I don't think there is a third option but I'd be very happy to learn something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't crash, even if user does not specify a stream error handler.