Skip to content

chore: drop eslint-plugin-markdown dep #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/serious-pigs-scream.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"eslint-mdx": minor
"eslint-plugin-mdx": minor
---

chore: drop `eslint-plugin-markdown` dep
3 changes: 1 addition & 2 deletions .codesandbox/ci.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"node": "18",
"installCommand": "codesandbox:install",
"node": "20",
"packages": [
"packages/*"
],
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ on:
- push
- pull_request

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
ci:
name: Lint and Test with Node.js ${{ matrix.node }} on ${{ matrix.os }}
Expand All @@ -16,6 +20,7 @@ jobs:
node:
- 18
- 20
fail-fast: false
runs-on: ${{ matrix.os }}
steps:
- name: Checkout Repo
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/pkg-size.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ on:
branches:
- master

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
pkg-size-report:
name: Package Size Report
Expand Down
2 changes: 2 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
.yarn
test/fixtures
935 changes: 935 additions & 0 deletions .yarn/releases/yarn-4.7.0.cjs

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions .yarnrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@ plugins:
- checksum: 37b2361b1502b2054e6779788c0e9bdd6a90ce49852a8cad2feda79b0614ec94f06fb6e78951f5f95429c610d7934dd077caa47413a0227378a102c55161616d
path: .yarn/plugins/plugin-prepare-lifecycle.cjs
spec: "https://github.com/un-es/yarn-plugin-prepare-lifecycle/releases/download/v0.0.1/index.js"

yarnPath: .yarn/releases/yarn-4.7.0.cjs
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ See [#251](https://github.com/mdx-js/eslint-mdx/issues/251#issuecomment-73613922
"mdx/code-blocks": true,
// optional, if you want to disable language mapper, set it to `false`
// if you want to override the default language mapper inside, you can provide your own
"mdx/language-mapper": {}
}
"mdx/language-mapper": {},
},
}
```

Expand Down Expand Up @@ -214,9 +214,9 @@ If you want to disable or change severity of some related rules, it won't work b
// disable following plugin
[
"lint-no-multiple-toplevel-headings",
[0] // or false
]
]
[0], // or false
],
],
}
```

Expand Down
52 changes: 26 additions & 26 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,12 @@
"workspaces": [
"packages/*"
],
"packageManager": "yarn@4.0.2",
"packageManager": "yarn@4.7.0",
"scripts": {
"build": "concurrently -r 'yarn:build:*'",
"build:r": "r -f es2015",
"build:ts": "tsc -b",
"clean": "rimraf --glob 'packages/*/{lib,*.tsbuildinfo}'",
"codesandbox:install": "yarn --ignore-engines",
"lint": "yarn build && concurrently -r 'yarn:lint:*'",
"lint:es": "eslint . --cache -f friendly",
"lint:tsc": "tsc --noEmit",
Expand All @@ -24,49 +23,50 @@
"release:only": "changeset publish",
"test": "cross-env NODE_OPTIONS=--experimental-vm-modules jest",
"typecov": "type-coverage",
"version": "changeset version && yarn --no-immutable"
"version": "changeset version && yarn --no-immutable",
"prettier": "prettier --log-level silent"
},
"devDependencies": {
"@1stg/common-config": "^10.0.0",
"@changesets/changelog-github": "^0.5.0",
"@changesets/cli": "^2.27.1",
"@commitlint/cli": "^18.4.4",
"@changesets/changelog-github": "^0.5.1",
"@changesets/cli": "^2.28.1",
"@commitlint/cli": "^18.6.1",
"@pkgr/rollup": "^5.0.0",
"@types/acorn": "^6.0.0",
"@types/eslint": "^8.56.1",
"@types/eslint-plugin-markdown": "^2.0.2",
"@types/jest": "^29.5.11",
"@types/node": "^20.10.6",
"@types/react": "^18.2.46",
"@types/unist": "^3.0.2",
"@types/acorn": "^6.0.4",
"@types/eslint": "^8.56.12",
"@types/jest": "^29.5.14",
"@types/node": "^20.17.24",
"@types/react": "^18.3.18",
"@types/unist": "^3.0.3",
"@unts/patch-package": "^8.1.1",
"concurrently": "^8.2.2",
"cross-env": "^7.0.3",
"eslint": "^8.56.0",
"jest": "^30.0.0-alpha.2",
"lint-staged": "^15.2.0",
"patch-package": "^8.0.0",
"prettier": "^3.1.1",
"react": "^18.2.0",
"rimraf": "^5.0.5",
"simple-git-hooks": "^2.9.0",
"ts-jest": "^29.1.1",
"eslint": "^8.57.1",
"jest": "^30.0.0-alpha.7",
"lint-staged": "^15.4.3",
"prettier": "^3.5.3",
"react": "^18.3.1",
"rimraf": "^5.0.10",
"simple-git-hooks": "^2.11.1",
"ts-jest": "^29.2.6",
"ts-node": "^10.9.2",
"type-coverage": "^2.27.1",
"typescript": "^5.3.3"
"type-coverage": "^2.29.7",
"typescript": "~5.3.3"
},
"resolutions": {
"@types/acorn": "^6.0.0",
"@types/mdast": "^4.0.3",
"@pkgr/utils": "^3.0.0",
"acorn": "^8.11.3",
"cliui": "npm:@isaacs/cliui@^8.0.2",
"eslint-mdx": "link:packages/eslint-mdx",
"eslint-plugin-markdown": "JounQin/eslint-plugin-markdown#feat/bump",
"eslint-plugin-mdx": "link:packages/eslint-plugin-mdx",
"mdast-util-frontmatter": "^2.0.1",
"mdast-util-gfm": "^3.0.0",
"unified": "^11.0.4",
"unified-engine": "^11.2.0",
"unist-util-visit": "^5.0.0"
"unist-util-visit": "^5.0.0",
"prettier": "^3.5.3"
},
"commitlint": {
"extends": [
Expand Down
10 changes: 5 additions & 5 deletions packages/eslint-mdx/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ See [#251](https://github.com/mdx-js/eslint-mdx/issues/251#issuecomment-73613922
"mdx/code-blocks": true,
// optional, if you want to disable language mapper, set it to `false`
// if you want to override the default language mapper inside, you can provide your own
"mdx/language-mapper": {}
}
"mdx/language-mapper": {},
},
}
```

Expand Down Expand Up @@ -214,9 +214,9 @@ If you want to disable or change severity of some related rules, it won't work b
// disable following plugin
[
"lint-no-multiple-toplevel-headings",
[0] // or false
]
]
[0], // or false
],
],
}
```

Expand Down
14 changes: 7 additions & 7 deletions packages/eslint-mdx/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,19 +30,19 @@
"eslint": ">=8.0.0"
},
"dependencies": {
"acorn": "^8.11.3",
"acorn": "^8.14.1",
"acorn-jsx": "^5.3.2",
"espree": "^9.6.1",
"estree-util-visit": "^2.0.0",
"remark-mdx": "^3.0.0",
"remark-mdx": "^3.1.0",
"remark-parse": "^11.0.0",
"remark-stringify": "^11.0.0",
"synckit": "^0.9.0",
"tslib": "^2.6.2",
"unified": "^11.0.4",
"unified-engine": "^11.2.0",
"synckit": "^0.9.2",
"tslib": "^2.8.1",
"unified": "^11.0.5",
"unified-engine": "^11.2.2",
"unist-util-visit": "^5.0.0",
"uvu": "^0.5.6",
"vfile": "^6.0.1"
"vfile": "^6.0.3"
}
}
1 change: 1 addition & 0 deletions packages/eslint-mdx/src/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export const getPhysicalFilename = (
const { code } = err as { code: string }
// https://github.com/eslint/eslint/issues/11989
// Additionally, it seems there is no `ENOTDIR` code on Windows...
// istanbul ignore if
if (code === 'ENOTDIR' || code === 'ENOENT') {
return getPhysicalFilename(path.dirname(filename), filename)
}
Expand Down
10 changes: 5 additions & 5 deletions packages/eslint-plugin-mdx/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ See [#251](https://github.com/mdx-js/eslint-mdx/issues/251#issuecomment-73613922
"mdx/code-blocks": true,
// optional, if you want to disable language mapper, set it to `false`
// if you want to override the default language mapper inside, you can provide your own
"mdx/language-mapper": {}
}
"mdx/language-mapper": {},
},
}
```

Expand Down Expand Up @@ -214,9 +214,9 @@ If you want to disable or change severity of some related rules, it won't work b
// disable following plugin
[
"lint-no-multiple-toplevel-headings",
[0] // or false
]
]
[0], // or false
],
],
}
```

Expand Down
11 changes: 6 additions & 5 deletions packages/eslint-plugin-mdx/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,13 @@
},
"dependencies": {
"eslint-mdx": "^3.1.5",
"eslint-plugin-markdown": "^3.0.1",
"remark-mdx": "^3.0.0",
"mdast-util-from-markdown": "^2.0.2",
"remark-mdx": "^3.1.0",
"remark-parse": "^11.0.0",
"remark-stringify": "^11.0.0",
"tslib": "^2.6.2",
"unified": "^11.0.4",
"vfile": "^6.0.1"
"synckit": "^0.9.2",
"tslib": "^2.8.1",
"unified": "^11.0.5",
"vfile": "^6.0.3"
}
}
6 changes: 6 additions & 0 deletions packages/eslint-plugin-mdx/src/processors/from-markdown.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import type { fromMarkdown as fromMarkdown_ } from 'mdast-util-from-markdown'
import { createSyncFn } from 'synckit'

export const fromMarkdown = createSyncFn(
require.resolve('./worker'),
) as typeof fromMarkdown_
Loading
Loading