-
-
Notifications
You must be signed in to change notification settings - Fork 34
fix: code block filename regexp group names missed #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (2)
- test/snapshots/fixtures.test.ts.snap: Language not supported
- test/fixtures/code-blocks/455.mdx: Language not supported
Comments suppressed due to low confidence (1)
packages/eslint-plugin-mdx/src/processors/markdown.ts:253
- The updated regex now includes named capture groups, but fileNameFromMeta still returns the full match result. Consider extracting and returning the value of the 'filename' group (e.g., using match?.groups?.filename) to make the code clearer and more robust.
function fileNameFromMeta(block: CodeBlock) {
Initial checklist
Description of changes
Introduced by #550, it should be related to auto fixing