Skip to content

Fix parameter changes in MySQLdb v2.1 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 17, 2022
Merged

Fix parameter changes in MySQLdb v2.1 #23

merged 5 commits into from
Mar 17, 2022

Conversation

kesmit13
Copy link
Collaborator

In MySQLdb v2.1, the parameters passwd and db were changed to password and database, respectively. This fix checks the version of MySQLdb and sets the parameter names accordingly.

@carlsverre
Copy link
Contributor

this resolves #20

carlsverre
carlsverre approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@carlsverre carlsverre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we limit it to &&<3.0 to prevent future similar problems?

@carlsverre carlsverre merged commit 2734600 into memsql:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlsverre carlsverre carlsverre approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kesmit13 @carlsverre