Skip to content

chore: suppress warnings on Windows #2089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 10, 2025

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Mar 10, 2025

Describe Your Changes

This pull request includes various changes across multiple files to improve code consistency, fix bugs, and enhance compatibility with different platforms. The most important changes include adding support for wide character conversion on Windows, ensuring compatibility with different compilers, and improving type safety.

Platform Compatibility Improvements:

  • engine/cli/main.cc: Added #include "utils/widechar_conv.h" and updated directory path handling to use Utf8ToWstring on Windows. [1] [2]
  • engine/services/hardware_service.cc: Added conditional compilation for environment variable handling to support _MSC_VER (Microsoft Compiler). [1] [2] [3]
  • engine/utils/cortex_utils.h: Updated GetDateRFC1123 function to use gmtime_s on Windows.
  • engine/utils/engine_matcher_utils.h: Updated sscanf to sscanf_s on Windows for secure parsing. (F0b0cb26L37R37)

Type Safety Enhancements:

Code Consistency:

Bug Fixes:

Other Changes:

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review March 10, 2025 07:56
@vansangpfiev vansangpfiev merged commit ae5bfa8 into dev Mar 10, 2025
16 checks passed
@vansangpfiev vansangpfiev deleted the s/chore/suppress-warnings-windows branch March 10, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants