fix: enable follow location option for get request #2131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vansangpfiev
changed the title
qnixsynapse
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
I did enable this in one of my PRs but it was still not working on @gau-nernst 's Fedora image for some reason. But LGTM
@gau-nernst Mind testing this to see if it works now?
|
@qnixsynapse I think we can merge. It's not too important for my case (Fedora docker) |
vansangpfiev
added a commit
that referenced
this pull request
Mar 17, 2025
Co-authored-by: sangjanai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request includes a small but important change to the
SimpleGetfunction in theengine/utils/curl_utils.ccfile. The change ensures that thecurlrequest will automatically follow HTTP redirects.engine/utils/curl_utils.cc: AddedCURLOPT_FOLLOWLOCATIONoption to thecurl_easy_setoptcall to follow HTTP redirects.Fixes Issues
Self Checklist