chore: Move to C++17 and fix extra warnings #2138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qnixsynapse
force-pushed
the
migrate_c17
branch
3 times, most recently
from
6f85bf0 to
a356bc8
Compare
qnixsynapse
force-pushed
the
migrate_c17
branch
from
f15d194 to
0abb204
Compare
qnixsynapse
changed the title
|
LGTM. |
|
Yup. I intend to enable CQA(which contains these flags) on *nix machines with valgrind and ASan. cc: @david-menloai |
vansangpfiev
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
The change migrates the codebase from C++20 to C++17 by replacing C++20's designated initialization with list initialization which is supported C++17 across platforms.
Currently, tested on Linux.
Also, fixed most compiler warning and removed/added attributes to some unused variables and functions
Fixes Issues
Self Checklist