Skip to content

bugfix: add more stringent out-of-bounds checks for GGUF parser #2159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

bugfix: add more stringent out-of-bounds checks for GGUF parser #2159

merged 1 commit into from
Mar 21, 2025

Conversation

gau-nernst
Copy link
Contributor

Describe Your Changes

  • Check for out-of-bounds whenever we read a value from GGUF mmap file
  • Add a test that fails before this PR

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@gau-nernst gau-nernst changed the title bug: add more stringent out-of-bounds checks for GGUF parser bugfix: add more stringent out-of-bounds checks for GGUF parser Mar 21, 2025
@gau-nernst gau-nernst self-assigned this Mar 21, 2025
@gau-nernst gau-nernst added this to Menlo Mar 21, 2025
@github-project-automation github-project-automation bot moved this to Investigating in Menlo Mar 21, 2025
@gau-nernst gau-nernst moved this from Investigating to Eng Review in Menlo Mar 21, 2025
@gau-nernst gau-nernst merged commit 3fef2db into dev Mar 21, 2025
8 checks passed
@gau-nernst gau-nernst deleted the thien/parser_oob branch March 21, 2025 02:10
@david-menloai david-menloai moved this from Eng Review to Completed in Menlo Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vansangpfiev vansangpfiev vansangpfiev approved these changes

@qnixsynapse qnixsynapse qnixsynapse approved these changes

Assignees

@gau-nernst gau-nernst

Labels
None yet
Projects
Menlo
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gau-nernst @vansangpfiev @qnixsynapse