fix: handle more parameters #2199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request introduces new parameters to the local engine configuration and enhances the parameter conversion functionality. The most important changes include adding the
caching_enabledparameter to the ignored parameters list and handling new parameterscache_typeanduse_mmapin the JSON to parameters vector conversion.Enhancements to parameter handling:
engine/extensions/local-engine/local_engine.cc: Addedcaching_enabledto the ignored parameters list (kIgnoredParams).engine/extensions/local-engine/local_engine.cc: UpdatedConvertJsonToParamsVectorto handlecache_typeanduse_mmapparameters.Fixes Issues
Self Checklist