Skip to content

fix: check model is loaded before starting #2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
Merged

Conversation

vansangpfiev
Copy link
Contributor

Describe Your Changes

This pull request introduces several updates to improve logging, enhance functionality, and fix redundant or unnecessary code in the engine's configuration, extensions, and services. Key changes include refining logging levels, adding new parameters for model handling, and addressing redundant variable declarations.

Logging Improvements:

  • Updated logging level from CTL_DBG to CTL_TRC in YamlHandler::ReadYamlFile to reduce verbosity for debug-level logs and align with trace-level logging. (engine/config/yaml_config.cc, engine/config/yaml_config.ccL51-R51)

New Features:

Code Simplification:

Parameter Updates:

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev force-pushed the s/fix/check-model-loaded branch from 9755e43 to 0d673f8 Compare May 15, 2025 23:38
@vansangpfiev vansangpfiev merged commit a90a5e8 into dev May 16, 2025
7 checks passed
@vansangpfiev vansangpfiev deleted the s/fix/check-model-loaded branch May 16, 2025 00:11
@github-project-automation github-project-automation bot moved this to QA in Jan May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: QA
Development

Successfully merging this pull request may close these issues.

2 participants