Skip to content

fix: check nodeType for dom elements #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 5, 2020
Merged

fix: check nodeType for dom elements #13

merged 6 commits into from
Apr 5, 2020

Conversation

merceyz
Copy link
Owner

@merceyz merceyz commented Mar 30, 2020 •
edited
Loading

Fixes #3
Closes #11

Implements proper handling of Element and HTMLElement types by checking their nodeType

eps1lon
eps1lon reviewed Mar 30, 2020
View reviewed changes
Copy link
Contributor

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said before most of the use cases don't care about the realm of the element. Node.nodeType is simpler and doesn't require ownerDocument lookups.

@merceyz merceyz changed the title fix: handle dom elements in different window frames fix: check nodeType for dom elements Apr 3, 2020
@merceyz
Copy link
Owner Author

merceyz commented Apr 3, 2020

@eps1lon @oliviertassinari Does this work for you?

@merceyz merceyz merged commit fd028e6 into master Apr 5, 2020
@merceyz merceyz deleted the dom-elements branch April 5, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon left review comments

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

instanceOf(Element) doesn't work in iframe
3 participants
@merceyz @oliviertassinari @eps1lon