Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started testing the HTTP transport using the provided server and client in examples/http_example. It didn't work for me, and I asked Cursor/Sonnet to help me with that. After adding logging to different parts of the code, we (of course, mostly Claude/Sonnet, not me) finally found the issue and fixed it. Now, the client works as expected and displays time in different formats. Here is the explanation and the changes:
Issue
The HTTP transport implementation had several issues that prevented proper message handling:
Changes
SetMessageHandler
to properly set the handler on the base transport while maintaining backward compatibilityresponseMap
field fromHTTPTransport
structresponseMap
initialization fromNewHTTPTransport
Send
method to use the correctresponseMap
from base transportImpact
Testing
The changes have been tested with JSON-RPC initialize requests and confirm that: