Skip to content

Fixed HTTPTransport - avoid overriding baseTransport fields #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed HTTPTransport - avoid overriding baseTransport fields #94

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5cc760
Fixed HTTPTransport - avoid overriding baseTransport fields
prasad83 Mar 29, 2025
24d2d78
Removed unnecessary import.
prasad83 Mar 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions transport/http/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import (
"encoding/json"
"fmt"
"net/http"
"sync"

"github.com/metoro-io/mcp-golang/transport"
)
Expand All @@ -15,12 +14,7 @@ type HTTPTransport struct {
*baseTransport
server *http.Server
endpoint string
messageHandler func(ctx context.Context, message *transport.BaseJsonRpcMessage)
errorHandler func(error)
closeHandler func()
mu sync.RWMutex
addr string
responseMap map[int64]chan *transport.BaseJsonRpcMessage
}

// NewHTTPTransport creates a new HTTP transport that listens on the specified endpoint
Expand All @@ -29,7 +23,6 @@ func NewHTTPTransport(endpoint string) *HTTPTransport {
baseTransport: newBaseTransport(),
endpoint: endpoint,
addr: ":8080", // Default port
responseMap: make(map[int64]chan *transport.BaseJsonRpcMessage),
}
}

Expand Down