changed assert with if statement (#116)

accelerated · mfontanini · commit d77e7466b821 · 2018-10-06T09:28:45.000-07:00
diff --git a/include/cppkafka/utils/buffered_producer.h b/include/cppkafka/utils/buffered_producer.h
@@ -849,9 +849,10 @@ void BufferedProducer<BufferType>::on_delivery_report(const Message& message) {
     if (tracker) {
         tracker->should_retry_.set_value(should_retry);
     }
-    // Decrement the expected acks
-    --pending_acks_;
-    assert(pending_acks_ != (size_t)-1); // Prevent underflow
+    // Decrement the expected acks and check to prevent underflow
+    if (pending_acks_ > 0) {
+        --pending_acks_;
+    }
 }
 
 } // cppkafka

Original file line number	Diff line number	Diff line change
`@@ -849,9 +849,10 @@ void BufferedProducer<BufferType>::on_delivery_report(const Message& message) {`
`849`	`849`	`if (tracker) {`
`850`	`850`	`tracker->should_retry_.set_value(should_retry);`
`851`	`851`	`}`
`852`		`- // Decrement the expected acks`
`853`		`- --pending_acks_;`
`854`		`- assert(pending_acks_ != (size_t)-1); // Prevent underflow`
	`852`	`+ // Decrement the expected acks and check to prevent underflow`
	`853`	`+ if (pending_acks_ > 0) {`
	`854`	`+ --pending_acks_;`
	`855`	`+ }`
`855`	`856`	`}`
`856`	`857`
`857`	`858`	`} // cppkafka`