Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed assert with if statement #116

Merged
merged 1 commit into from
Oct 6, 2018

Conversation

accelerated
Copy link
Contributor

In all the testing we have done (and quite extensively) this assert happened only once. However we run debug builds in production and this assert can't happen otherwise the task crashes. I suspect, it's something to do with the underlying rdkafka library where either a message delivery callback was called twice or there was a duplicate ack from kafka, or something like that. I checked the buffered producer code and the pending_acks_ is only incremented in a single place. It could also be that produce() actually sent the message but returned an error afterwards, meaning the pending_acks_ counter was not incremented but kafka still sent an ack back. In any case, this happened only once.

@mfontanini
Copy link
Owner

This looks like rdkafka's issue, the pending acks tracking here doesn't seem to be wrong. Maybe it's worth raising a bug on their side. Thanks for the fix!

@mfontanini mfontanini merged commit d77e746 into mfontanini:master Oct 6, 2018
@accelerated
Copy link
Contributor Author

Ok will do.

@accelerated accelerated deleted the pending_acks branch October 10, 2018 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants