Remove setting log level in the constructor #136
Merged
+0
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the log level in the producer and consumer constructor can interfere with the user setting the
log_level
rdkafka option which essentially gets overriden to Err level. It's best to either let the user specify it vialog_level
rdkafka option or via theKafkaHandleBase::set_log_level
api.As an alternative, we could check if the user has set the
log_level
option and if so, not call theset_log_level
api. But it feels hackish.