Skip to content

Remove setting log level in the constructor #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2018

Conversation

accelerated
Copy link
Contributor

Setting the log level in the producer and consumer constructor can interfere with the user setting the log_level rdkafka option which essentially gets overriden to Err level. It's best to either let the user specify it via log_level rdkafka option or via the KafkaHandleBase::set_log_level api.

As an alternative, we could check if the user has set the log_level option and if so, not call the set_log_level api. But it feels hackish.

@mfontanini
Copy link
Owner

This makes sense, the log level setting shouldn't have been there from the start. Thanks!

@mfontanini mfontanini merged commit 4b7a10e into mfontanini:master Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants