Skip to content

Fixed deprecated error function call #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 4, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,14 +76,18 @@ If you have installed _librdkafka_ on a non standard directory, you can use the
cmake .. -DRDKAFKA_ROOT_DIR=/some/other/dir
```

Note that finding _librdkafka_ will succeed iff there's an _include_ and _lib_
directories inside the specified path, including both the _rdkafka.h_ header
and the _librdkafka_ library file.
Note that the `RDKAFKA_ROOT_DIR` must contain the following structure:

---
```Shell
${RDKAFKA_ROOT_DIR}/
|
+ include/librdkafka/rdkafka.h
|
+ lib/librdkafka.a
```

By default, a shared library will be built. If you want to perform a static build,
use the _CPPKAFKA_BUILD_SHARED_ parameter:
use the `CPPKAFKA_BUILD_SHARED` parameter:

```Shell
cmake .. -DCPPKAFKA_BUILD_SHARED=0
Expand Down
2 changes: 1 addition & 1 deletion src/kafka_handle_base.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ void KafkaHandleBase::set_handle(rd_kafka_t* handle) {
Topic KafkaHandleBase::get_topic(const string& name, rd_kafka_topic_conf_t* conf) {
rd_kafka_topic_t* topic = rd_kafka_topic_new(get_handle(), name.data(), conf);
if (!topic) {
throw HandleException(rd_kafka_errno2err(errno));
throw HandleException(rd_kafka_last_error());
}
return Topic(topic);
}
Expand Down