Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added purge (aka async_flush) functionality #79

Merged
merged 3 commits into from
Jun 12, 2018

Conversation

accelerated
Copy link
Contributor

Added asynchronous flush capability.

@accelerated
Copy link
Contributor Author

If you can merge this that would be great! Cheers!

@mfontanini
Copy link
Owner

I really thought I had merged this one, sorry :(. Anyway, I imagine you wanted the other one merged first so I went for that one.

@accelerated
Copy link
Contributor Author

Before I resolve the conflicts, I actually had one question for you...i was debating if purge was the right name here or perhaps async_flush. Do you have any preferences? I think async_flush is easier to understand what it does, but there there's produce and sync_produce so people might wonder why intermixing sync and async as it's not consistent.

@mfontanini
Copy link
Owner

True, "purge" maybe sounds like you're getting rid of the messages rather than sending them. I'm not great at naming things but I think async_flush could work. I can't think of any other names... This is like some sort of "light flush" but that doesn't sound right.

@accelerated
Copy link
Contributor Author

ok cool, I'll change the name and push the update in a few mins.

@accelerated
Copy link
Contributor Author

Done!

@mfontanini mfontanini merged commit 157b7ec into mfontanini:master Jun 12, 2018
@mfontanini
Copy link
Owner

Thanks!

@accelerated accelerated deleted the purge branch June 12, 2018 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants