Skip to content

Fix function isBase64 #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2024
Merged

Fix function isBase64 #117

merged 2 commits into from
Feb 11, 2024

Conversation

leey00nsu
Copy link
Contributor

@leey00nsu leey00nsu commented Jan 29, 2024

Hello. Thank you for maintaining the library.

Environment

"octokit-commit-multiple-files": "^5.0.0",

Issue

When uploading an image, if the size of the base64 exceeds 5MB, the error Maximum call stack size exceeded occurs.

Changes

I found the solution here . It was an issue with the isBase64 library, and changing that function resolved the issue.

Log

Error creating commit: RangeError: Maximum call stack size exceeded
    at RegExp.test (<anonymous>)
    at isBase64 (webpack-internal:///(action-browser)/./node_modules/is-base64/is-base64.js:24:52)
    at createBlob (webpack-internal:///(action-browser)/./node_modules/octokit-commit-multiple-files/create-or-update-files.js:181:14)
    at eval (webpack-internal:///(action-browser)/./node_modules/octokit-commit-multiple-files/create-or-update-files.js:95:47)
    at Array.map (<anonymous>)
    at eval (webpack-internal:///(action-browser)/./node_modules/octokit-commit-multiple-files/create-or-update-files.js:87:45)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
Error creating commit: Maximum call stack size exceeded

@mheap
Copy link
Owner

mheap commented Feb 11, 2024

Thank you for the PR! I've just validated locally and will release an updated version shortly

@mheap mheap merged commit 67840fc into mheap:main Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants