feat: introduce batched requests for async-loops #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome, thanks @shouyang! |
|
Released as v4.2.0 |
|
Hey @mheap, could you update the npm releases, I see the latest as 4.1.0? |
|
@shouyang It looks as though the release job failed, then I missed this notification 🤦 4.2.0 is now released. Thank you for your patience |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mheap
Hey there, I've been using the plugin to automate translating UI resource files and committing back the translated versions. I'm committing back ~30-50 small files and I've found the need to batch the section on
createBlob. For completeness, I've also done the same with the other await-loop surroundingfileExistsInRepofor deleting files.What's been done:
batchSize, defaulting ton = 1.batchSize, split the change parameters intonconcurrent requests, and map-and-await them using the existing implementation viaPromise.all.