Add ESP32 support #680
Merged
Add ESP32 support #680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogs9
reviewed
Jan 11, 2022
pablogs9
reviewed
Jan 12, 2022
pablogs9
reviewed
Jan 12, 2022
Comment on lines
56
to
59
| # Workaround. Remove when https://github.com/ros2/rosidl/pull/596 is merged | ||
| touch firmware/mcu_ws/ros2/common_interfaces/actionlib_msgs/COLCON_IGNORE; | ||
| touch firmware/mcu_ws/ros2/common_interfaces/std_srvs/COLCON_IGNORE; | ||
| touch firmware/mcu_ws/ros2/example_interfaces/COLCON_IGNORE; |
There was a problem hiding this comment.
ros2/rosidl#596 is merged, does this work without these lines?
There was a problem hiding this comment.
Yes! Deleted here: cd7c3d2
There was a problem hiding this comment.
This includes new packages and modifies all libraries, so I think its better to rebuild.
This commit will trigger the build and will serve as a test: 8922276
|
@mergify backport foxy main |
🟠 Waiting for conditions to match
Hey, I reacted but my real name is @Mergifyio |
pablogs9
approved these changes
Jan 12, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jan 12, 2022
* Fix wifi example * Update ci and library properties * Add esp32 build step * Update readme * Add esp32 library to test CI * Fix CI * Fix build for Arduino nano * Fix esp32 CI compilation * Install pyserial for esp32 * Install pip3 on CI * Revert commit and add pip3 * Update library_generation.sh with changes check * Remove redundant code * Trigger build (cherry picked from commit a809407) # Conflicts: # .github/workflows/ci.yml # extras/library_generation/library_generation.sh
mergify bot
pushed a commit
that referenced
this pull request
Jan 12, 2022
* Fix wifi example * Update ci and library properties * Add esp32 build step * Update readme * Add esp32 library to test CI * Fix CI * Fix build for Arduino nano * Fix esp32 CI compilation * Install pyserial for esp32 * Install pip3 on CI * Revert commit and add pip3 * Update library_generation.sh with changes check * Remove redundant code * Trigger build (cherry picked from commit a809407) # Conflicts: # built_packages # extras/library_generation/library_generation.sh
✅ Backports have been created
|
Acuadros95
added a commit
that referenced
this pull request
Jan 12, 2022
* Add ESP32 support (#680) * Fix wifi example * Update ci and library properties * Add esp32 build step * Update readme * Add esp32 library to test CI * Fix CI * Fix build for Arduino nano * Fix esp32 CI compilation * Install pyserial for esp32 * Install pip3 on CI * Revert commit and add pip3 * Update library_generation.sh with changes check * Remove redundant code * Trigger build (cherry picked from commit a809407) # Conflicts: # .github/workflows/ci.yml # extras/library_generation/library_generation.sh * Fix conflicts Co-authored-by: Antonio Cuadros <[email protected]> Co-authored-by: acuadros95 <[email protected]>
Acuadros95
added a commit
that referenced
this pull request
Jan 12, 2022
* Add ESP32 support (#680) * Fix wifi example * Update ci and library properties * Add esp32 build step * Update readme * Add esp32 library to test CI * Fix CI * Fix build for Arduino nano * Fix esp32 CI compilation * Install pyserial for esp32 * Install pip3 on CI * Revert commit and add pip3 * Update library_generation.sh with changes check * Remove redundant code * Trigger build (cherry picked from commit a809407) # Conflicts: # built_packages # extras/library_generation/library_generation.sh * Fix conflicts * Fix conflict Co-authored-by: Antonio Cuadros <[email protected]> Co-authored-by: acuadros95 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.