Fix regression aligment #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## galactic #46 +/- ##
==========================================
Coverage ? 0.00%
==========================================
Files ? 1
Lines ? 9
Branches ? 2
==========================================
Hits ? 0
Misses ? 9
Partials ? 0 Continue to review full report at Codecov.
|
Signed-off-by: Pablo Garrido <[email protected]> Update Signed-off-by: Pablo Garrido <[email protected]> Update Signed-off-by: Pablo Garrido <[email protected]> Update Signed-off-by: Pablo Garrido <[email protected]> Update Signed-off-by: Pablo Garrido <[email protected]> Refactor tests Signed-off-by: Pablo Garrido <[email protected]> Update Signed-off-by: Pablo Garrido <[email protected]> Update Signed-off-by: Pablo Garrido <[email protected]> Update Signed-off-by: Pablo Garrido <[email protected]> Update Signed-off-by: Pablo Garrido <[email protected]> Update Signed-off-by: Pablo Garrido <[email protected]> Install fastrtps rmw Signed-off-by: Pablo Garrido <[email protected]> Update Signed-off-by: Pablo Garrido <[email protected]>
This reverts commit 2811d1a.
Signed-off-by: Pablo Garrido <[email protected]>
pablogs9
force-pushed
the
fix/regression_aligment
branch
from
2b51649 to
e72a07b
Compare
This reverts commit e72a07b.
Signed-off-by: Pablo Garrido <[email protected]>
Signed-off-by: Pablo Garrido <[email protected]>
|
@Acuadros95 Could you please take a look at that. As we mentioned, I have prepared a minimal framework for cross serializing between Micro CDR and Fast CDR. 72669cd is the regression test and 850e97f is the fix for this specific regression. |
Acuadros95
reviewed
May 17, 2022
Acuadros95
reviewed
May 17, 2022
Co-authored-by: Antonio Cuadros <[email protected]>
Signed-off-by: Pablo Garrido <[email protected]>
Acuadros95
approved these changes
May 17, 2022
Acuadros95
approved these changes
May 18, 2022
|
@mergify backport main foxy humble |
🟠 Waiting for conditions to match
|
mergify bot
pushed a commit
that referenced
this pull request
May 18, 2022
(cherry picked from commit e8e371e)
mergify bot
pushed a commit
that referenced
this pull request
May 18, 2022
(cherry picked from commit e8e371e)
mergify bot
pushed a commit
that referenced
this pull request
May 18, 2022
(cherry picked from commit e8e371e)
✅ Backports have been created
|
|
@bjv-capra ping, this solves the alignment issue you had. |
pablogs9
added a commit
that referenced
this pull request
May 18, 2022
(cherry picked from commit e8e371e) Co-authored-by: Pablo Garrido <[email protected]>
pablogs9
added a commit
that referenced
this pull request
May 18, 2022
(cherry picked from commit e8e371e) Co-authored-by: Pablo Garrido <[email protected]>
pablogs9
added a commit
that referenced
this pull request
May 18, 2022
(cherry picked from commit e8e371e) Co-authored-by: Pablo Garrido <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pablo Garrido [email protected]