Remove explicit log processor env var #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremydvoss
reviewed
Aug 15, 2023
CHANGELOG.md
Outdated
| @@ -4,6 +4,8 @@ | |||
|
|
|||
| - Unpin OTel SDK/API version | |||
| ([#310](https://github.com/microsoft/ApplicationInsights-Python/pull/310)) | |||
| - Replace custom log processor exporter interval env var with OT SDK env var | |||
There was a problem hiding this comment.
It's always been the OT env var. Just a question of whether we use it on our end or leave it for the OTel sdk (which previously failed to do so).
There was a problem hiding this comment.
Changed to read "explicit" instead of custom. No logic is needed in our distro when it pertains to configuring export interval as we are leveraging OT SDK env vars.
Misleading description. What custom env var are you talking about? |
lzchen
changed the title
jeremydvoss
approved these changes
Aug 15, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now leveraging OT env vars for our configuration instead of custom ones. Confirmed that OT sdk uses OTEL_BLRP_SCHEDULE_DELAY as specified here in the usage docs.
Fixes #265
PR that added these env vars to OT sdk: open-telemetry/opentelemetry-python#3237