Injecting credential vault into Developer ID Provider (#202)

* Injecting credential vault into developeridprovider

* Spacing

* Fixing tests

Author: guimafelipe

Diff for: GitHubExtension.Test/Controls/SignInFormTest.cs

@@ -27,7 +27,8 @@ public async Task HandleOAuthRedirection_ShouldThrowInvalidOperationException_On
                 return new OauthToken();
             });
 
-        var developerIdProvider = new DeveloperIdProvider();
+        var mockCredentialVault = new Mock<ICredentialVault>();
+        var developerIdProvider = new DeveloperIdProvider(mockCredentialVault.Object);
 
         mockGitHubClient.Setup(client => client.Oauth).Returns(mockOauthClient.Object);
 

Diff for: GitHubExtension.Test/DataStoreTests/DataManagerTests.cs

@@ -6,12 +6,13 @@
 using GitHubExtension.DataManager.Cache;
 using GitHubExtension.DataManager.Data;
 using GitHubExtension.DeveloperId;
+using Moq;
 
 namespace GitHubExtension.Test.DataStoreTests;
 
 public partial class DataStoreTests
 {
-    private DeveloperIdProvider GetDeveloperIdProvider() => new();
+    private DeveloperIdProvider GetDeveloperIdProvider() => new(new Mock<ICredentialVault>().Object);
 
     private GitHubClientProvider GetGitHubClientProvider(DeveloperIdProvider developerIdProvider) =>
         new(developerIdProvider);

Diff for: GitHubExtension.Test/DataStoreTests/OctokitIngestionTests.cs

@@ -8,6 +8,7 @@
 using GitHubExtension.DataModel.DataObjects;
 using GitHubExtension.DeveloperId;
 using GitHubExtension.Test.Helpers;
+using Moq;
 using Octokit;
 
 namespace GitHubExtension.Test.DataStoreTests;
@@ -30,7 +31,8 @@ public void AddUserFromOctokit()
             "octokit",
         };
 
-        var client = new GitHubClientProvider(new DeveloperIdProvider()).GetClient();
+        var mockCredentialVault = new Mock<ICredentialVault>();
+        var client = new GitHubClientProvider(new DeveloperIdProvider(mockCredentialVault.Object)).GetClient();
         using var tx = dataStore.Connection!.BeginTransaction();
         foreach (var item in items)
         {
@@ -82,7 +84,8 @@ public void AddRepositoryFromOctokit()
             Tuple.Create("microsoft", "WindowsAppSDK"),
         };
 
-        var client = new GitHubClientProvider(new DeveloperIdProvider()).GetClient();
+        var mockCredentialVault = new Mock<ICredentialVault>();
+        var client = new GitHubClientProvider(new DeveloperIdProvider(mockCredentialVault.Object)).GetClient();
         using var tx = dataStore.Connection!.BeginTransaction();
         foreach (var item in items)
         {
@@ -154,7 +157,8 @@ public void AddPullRequestFromOctokit()
             Tuple.Create("microsoft", "WindowsAppSDK", 3482, 2),
         };
 
-        var client = new GitHubClientProvider(new DeveloperIdProvider()).GetClient();
+        var mockCredentialVault = new Mock<ICredentialVault>();
+        var client = new GitHubClientProvider(new DeveloperIdProvider(mockCredentialVault.Object)).GetClient();
         using var tx = dataStore.Connection!.BeginTransaction();
 
         foreach (var repo in repositories)
@@ -249,7 +253,8 @@ public void AddIssueFromOctokit()
             Tuple.Create("microsoft", "WindowsAppSDK", 12, 2),
         };
 
-        var client = new GitHubClientProvider(new DeveloperIdProvider()).GetClient();
+        var mockCredentialVault = new Mock<ICredentialVault>();
+        var client = new GitHubClientProvider(new DeveloperIdProvider(mockCredentialVault.Object)).GetClient();
         using var tx = dataStore.Connection!.BeginTransaction();
 
         foreach (var repo in repositories)
@@ -326,7 +331,8 @@ public void AddPullRequestLabelFromOctokit()
         dataStore.Create();
         Assert.IsNotNull(dataStore.Connection);
 
-        var client = new GitHubClientProvider(new DeveloperIdProvider()).GetClient();
+        var mockCredentialVault = new Mock<ICredentialVault>();
+        var client = new GitHubClientProvider(new DeveloperIdProvider(mockCredentialVault.Object)).GetClient();
 
         using var tx = dataStore.Connection!.BeginTransaction();
 
@@ -382,7 +388,8 @@ public void AddIssueLabelFromOctokit()
         dataStore.Create();
         Assert.IsNotNull(dataStore.Connection);
 
-        var client = new GitHubClientProvider(new DeveloperIdProvider()).GetClient();
+        var mockCredentialVault = new Mock<ICredentialVault>();
+        var client = new GitHubClientProvider(new DeveloperIdProvider(mockCredentialVault.Object)).GetClient();
 
         using var tx = dataStore.Connection!.BeginTransaction();