Injecting credential vault into Developer ID Provider

[guimafelipe]

No description provided.

[Copilot]

Pull Request Overview

This PR injects a CredentialVault into the DeveloperIdProvider to decouple the credential management implementation from the provider and improve dependency injection practices. Key changes include:

• Instantiating CredentialVault in Program.cs and passing it to DeveloperIdProvider.
• Updating ICredentialVault interface visibility from internal to public.
• Refactoring DeveloperIdProvider to remove lazy initialization and use the injected ICredentialVault directly.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

File	Description
GitHubExtension/Program.cs	Instantiates CredentialVault and injects it into DeveloperIdProvider.
GitHubExtension/DeveloperId/ICredentialVault.cs	Changes interface visibility to public.
GitHubExtension/DeveloperId/DeveloperIdProvider.cs	Refactors to replace Lazy with direct dependency injection, updating all corresponding method calls.

Comments suppressed due to low confidence (2)

GitHubExtension/DeveloperId/DeveloperIdProvider.cs:59

• Ensure that tests cover scenarios where retrieving credentials from the injected ICredentialVault might yield empty or unexpected data, validating the restore functionality.

RestoreDeveloperIds(_credentialVault.GetAllCredentials());

GitHubExtension/DeveloperId/DeveloperIdProvider.cs:267

• Update tests to confirm that saving and subsequent removal of credentials via the injected ICredentialVault behave as expected, ensuring overall integration consistency.

_credentialVault.SaveCredentials(