Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Pipeline #196

Merged
merged 2 commits into from
Mar 27, 2025
Merged

Improving Pipeline #196

merged 2 commits into from
Mar 27, 2025

Conversation

guimafelipe
Copy link
Collaborator

@guimafelipe guimafelipe commented Mar 22, 2025

  • This change adds the version number to the msix filename, so it gets clearer to the users which version they are getting.
  • We are also changing the Test.ps1 to run all the tests that are not marked as LiveData, so we don't need to mark everything as Unit for the test to be run.
  • This PR also removes UI testing logic from Test.ps1, as we are not using it on our extension and don't plan to use it in the foreseeable future.
  • This also changes some logic on Build.ps1 so we can in the future change the Azure pipeline to use it instead of the standard pipeline tasks, giving us more control of how it builds and also giving users the option of building the project locally using the script.

@Copilot Copilot bot review requested due to automatic review settings March 22, 2025 05:46
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request aims to improve the pipeline by replacing two separate tasks with a single PowerShell task for building the MSIX package.

  • Removed the MSBuild task for restoring packages
  • Removed the MsixPackaging task and replaced it with a PowerShell task that runs Build.ps1
Files not reviewed (2)
  • build/scripts/Build.ps1: Language not supported
  • build/scripts/Test.ps1: Language not supported
Comments suppressed due to low confidence (1)

build/azure-pipelines.yml:68

  • The removal of the MSBuild@1 task for restoring packages may lead to missing dependencies during the build process if package restoration is not being handled elsewhere. Please confirm that package restoration is adequately managed in the updated pipeline.
- task: PowerShell@2

@lauren-ciha lauren-ciha merged commit dab50a1 into main Mar 27, 2025
4 checks passed
@lauren-ciha lauren-ciha deleted the user/felipeda/improvingpipeline4 branch March 27, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants