Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing build folder path for signing #204

Merged
merged 3 commits into from
Mar 27, 2025
Merged

Conversation

guimafelipe
Copy link
Collaborator

No description provided.

@Copilot Copilot bot review requested due to automatic review settings March 27, 2025 22:32
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the build folder path for code signing by updating the folder path used in the Azure Pipelines YAML configuration.

  • Updates the FolderPath parameter to include the app package directory and configuration variables.
Comments suppressed due to low confidence (1)

build/azure-pipelines.yml:78

  • The updated FolderPath uses a mix of variable substitution syntaxes ($(...) and ${{...}}) with a backslash separator. Verify that this combination produces the intended path and consider using a consistent substitution approach to avoid potential path resolution issues.
                      FolderPath: '$(appxPackageDir)\${{ configuration }}'

@guimafelipe guimafelipe requested a review from Copilot March 27, 2025 23:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • build/scripts/Build.ps1: Language not supported

@guimafelipe guimafelipe requested a review from lauren-ciha March 27, 2025 23:38
@guimafelipe guimafelipe merged commit 4dad19c into main Mar 27, 2025
4 checks passed
@guimafelipe guimafelipe deleted the user/felipeda/pipelinefix2 branch March 27, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants