Skip to content

Add mediator classes #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 2, 2025
Merged

Add mediator classes #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0b3254e
Add decomposition function in Program
lauren-ciha Apr 1, 2025
e3de813
Make SaveSearchForm.SearchSaved an instance method
lauren-ciha Apr 2, 2025
085a41f
Make signInForm.SignInAction an instance event
lauren-ciha Apr 2, 2025
678e4a1
Make SignOutForm.SignOutAction an instance event
lauren-ciha Apr 2, 2025
69f01a1
Update RaiseItemsChanged() to pass in 0
lauren-ciha Apr 2, 2025
f86e179
Create mediator for remove search events
lauren-ciha Apr 2, 2025
8059f08
Add AuthenticationMediator
lauren-ciha Apr 2, 2025
cbed932
Update tests
lauren-ciha Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 28 additions & 21 deletions GitHubExtension.Test/Controls/GitHubQueryValidationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,19 @@ namespace GitHubExtension.Test.Controls;
[TestClass]
public class GitHubQueryValidationTests
{
public SaveSearchForm CreateSaveSearchForm(Mock<ISearchRepository> mockSearchRepository)
{
var mockResources = new Mock<IResources>();
var savedSearchesMediator = new SavedSearchesMediator();
return new SaveSearchForm(mockSearchRepository.Object, mockResources.Object, savedSearchesMediator);
}

[TestMethod]
public async Task ValidateSearch_SupportsIsOpenKeyword()
{
var mockSearchRepository = new Mock<ISearchRepository>();
var mockResources = new Mock<IResources>();
var saveSearchForm = new SaveSearchForm(mockSearchRepository.Object, mockResources.Object);
var saveSearchForm = CreateSaveSearchForm(mockSearchRepository);

var searchString = "is:open";
var search = new SearchCandidate(searchString, "Test Search");
Expand All @@ -35,7 +42,7 @@ public async Task ValidateSearch_SupportsIsIssueKeyword()
{
var mockSearchRepository = new Mock<ISearchRepository>();
var mockResources = new Mock<IResources>();
var saveSearchForm = new SaveSearchForm(mockSearchRepository.Object, mockResources.Object);
var saveSearchForm = CreateSaveSearchForm(mockSearchRepository);

var searchString = "is:issue";
var search = new SearchCandidate(searchString, "Test Search");
Expand All @@ -53,7 +60,7 @@ public async Task ValidateSearch_SupportsIsPullRequestKeyword()
{
var mockSearchRepository = new Mock<ISearchRepository>();
var mockResources = new Mock<IResources>();
var saveSearchForm = new SaveSearchForm(mockSearchRepository.Object, mockResources.Object);
var saveSearchForm = CreateSaveSearchForm(mockSearchRepository);

var searchString = "is:pr";
var search = new SearchCandidate(searchString, "Test Search");
Expand All @@ -70,7 +77,7 @@ public async Task ValidateSearch_SupportsMultipleKeywords()
{
var mockSearchRepository = new Mock<ISearchRepository>();
var mockResources = new Mock<IResources>();
var saveSearchForm = new SaveSearchForm(mockSearchRepository.Object, mockResources.Object);
var saveSearchForm = CreateSaveSearchForm(mockSearchRepository);

var searchString = "is:open is:issue";
var search = new SearchCandidate(searchString, "Test Search");
Expand All @@ -87,7 +94,7 @@ public async Task ValidateSearch_SupportsRepoQualifier()
{
var mockSearchRepository = new Mock<ISearchRepository>();
var mockResources = new Mock<IResources>();
var saveSearchForm = new SaveSearchForm(mockSearchRepository.Object, mockResources.Object);
var saveSearchForm = CreateSaveSearchForm(mockSearchRepository);

var searchString = "is:issue repo:microsoft/PowerToys";

Expand All @@ -103,7 +110,7 @@ public async Task ValidateSearch_SupportsAuthorQualifier()
{
var mockSearchRepository = new Mock<ISearchRepository>();
var mockResources = new Mock<IResources>();
var saveSearchForm = new SaveSearchForm(mockSearchRepository.Object, mockResources.Object);
var saveSearchForm = CreateSaveSearchForm(mockSearchRepository);

var searchString = "is:pr author:octocat";

Expand All @@ -119,7 +126,7 @@ public async Task ValidateSearch_SupportsStateAndLabelQualifiers()
{
var mockSearchRepository = new Mock<ISearchRepository>();
var mockResources = new Mock<IResources>();
var saveSearchForm = new SaveSearchForm(mockSearchRepository.Object, mockResources.Object);
var saveSearchForm = CreateSaveSearchForm(mockSearchRepository);

var searchString = "state:open label:bug";

Expand All @@ -135,7 +142,7 @@ public async Task ValidateSearch_SupportsInvolvesAndLanguageQualifiers()
{
var mockSearchRepository = new Mock<ISearchRepository>();
var mockResources = new Mock<IResources>();
var saveSearchForm = new SaveSearchForm(mockSearchRepository.Object, mockResources.Object);
var saveSearchForm = CreateSaveSearchForm(mockSearchRepository);

var searchString = "involves:defunkt language:javascript";

Expand All @@ -151,7 +158,7 @@ public async Task ValidateSearch_SupportsOrgAndCreatedQualifiers()
{
var mockSearchRepository = new Mock<ISearchRepository>();
var mockResources = new Mock<IResources>();
var saveSearchForm = new SaveSearchForm(mockSearchRepository.Object, mockResources.Object);
var saveSearchForm = CreateSaveSearchForm(mockSearchRepository);

var searchString = "org:github created:>2022-01-01";

Expand All @@ -167,7 +174,7 @@ public async Task ValidateSearch_SupportsAssigneeAndMilestoneQualifiers()
{
var mockSearchRepository = new Mock<ISearchRepository>();
var mockResources = new Mock<IResources>();
var saveSearchForm = new SaveSearchForm(mockSearchRepository.Object, mockResources.Object);
var saveSearchForm = CreateSaveSearchForm(mockSearchRepository);

var searchString = "is:issue assignee:@me milestone:v1.0";

Expand All @@ -183,7 +190,7 @@ public async Task ValidateSearch_SupportsReviewQualifier()
{
var mockSearchRepository = new Mock<ISearchRepository>();
var mockResources = new Mock<IResources>();
var saveSearchForm = new SaveSearchForm(mockSearchRepository.Object, mockResources.Object);
var saveSearchForm = CreateSaveSearchForm(mockSearchRepository);

var searchString = "is:pr review:approved";

Expand All @@ -199,7 +206,7 @@ public async Task ValidateSearch_SupportsInQualifier()
{
var mockSearchRepository = new Mock<ISearchRepository>();
var mockResources = new Mock<IResources>();
var saveSearchForm = new SaveSearchForm(mockSearchRepository.Object, mockResources.Object);
var saveSearchForm = CreateSaveSearchForm(mockSearchRepository);

var searchString = "is:issue in:title error";

Expand All @@ -215,7 +222,7 @@ public async Task ValidateSearch_SupportsMergedDateQualifier()
{
var mockSearchRepository = new Mock<ISearchRepository>();
var mockResources = new Mock<IResources>();
var saveSearchForm = new SaveSearchForm(mockSearchRepository.Object, mockResources.Object);
var saveSearchForm = CreateSaveSearchForm(mockSearchRepository);

var searchString = "is:pr merged:>=2023-01-01";

Expand All @@ -231,7 +238,7 @@ public async Task ValidateSearch_SupportsSingleLabelQualifier()
{
var mockSearchRepository = new Mock<ISearchRepository>();
var mockResources = new Mock<IResources>();
var saveSearchForm = new SaveSearchForm(mockSearchRepository.Object, mockResources.Object);
var saveSearchForm = CreateSaveSearchForm(mockSearchRepository);

var searchString = "label:enhancement";

Expand All @@ -247,7 +254,7 @@ public async Task ValidateSearch_SupportsMultipleLabelQualifiers()
{
var mockSearchRepository = new Mock<ISearchRepository>();
var mockResources = new Mock<IResources>();
var saveSearchForm = new SaveSearchForm(mockSearchRepository.Object, mockResources.Object);
var saveSearchForm = CreateSaveSearchForm(mockSearchRepository);

var searchString = "label:bug label:help-wanted label:documentation";

Expand All @@ -263,7 +270,7 @@ public async Task ValidateSearch_SupportsExcludingLabel()
{
var mockSearchRepository = new Mock<ISearchRepository>();
var mockResources = new Mock<IResources>();
var saveSearchForm = new SaveSearchForm(mockSearchRepository.Object, mockResources.Object);
var saveSearchForm = CreateSaveSearchForm(mockSearchRepository);

var searchString = "-label:wontfix";

Expand All @@ -279,7 +286,7 @@ public async Task ValidateSearch_SupportsExcludingMultipleLabels()
{
var mockSearchRepository = new Mock<ISearchRepository>();
var mockResources = new Mock<IResources>();
var saveSearchForm = new SaveSearchForm(mockSearchRepository.Object, mockResources.Object);
var saveSearchForm = CreateSaveSearchForm(mockSearchRepository);

var searchString = "-label:wontfix -label:duplicate -label:invalid";

Expand All @@ -295,7 +302,7 @@ public async Task ValidateSearch_SupportsExcludingOtherQualifiers()
{
var mockSearchRepository = new Mock<ISearchRepository>();
var mockResources = new Mock<IResources>();
var saveSearchForm = new SaveSearchForm(mockSearchRepository.Object, mockResources.Object);
var saveSearchForm = CreateSaveSearchForm(mockSearchRepository);

var searchString = "is:issue -is:closed -author:bot";

Expand All @@ -312,7 +319,7 @@ public async Task ValidateSearch_SupportsMixOfIncludeAndExcludeQualifiers()
{
var mockSearchRepository = new Mock<ISearchRepository>();
var mockResources = new Mock<IResources>();
var saveSearchForm = new SaveSearchForm(mockSearchRepository.Object, mockResources.Object);
var saveSearchForm = CreateSaveSearchForm(mockSearchRepository);

var searchString = "is:pr label:enhancement -label:wontfix repo:microsoft/PowerToys -is:draft";

Expand All @@ -329,7 +336,7 @@ public async Task ValidateSearch_SupportsBooleanOperators()
{
var mockSearchRepository = new Mock<ISearchRepository>();
var mockResources = new Mock<IResources>();
var saveSearchForm = new SaveSearchForm(mockSearchRepository.Object, mockResources.Object);
var saveSearchForm = CreateSaveSearchForm(mockSearchRepository);

var searchString = "is:open AND (is:issue OR is:pr) NOT author:bot devhome";
var search = new SearchCandidate(searchString, "Test Search");
Expand All @@ -346,7 +353,7 @@ public async Task ValidateSearch_SupportsMultipleRepositories()
{
var mockSearchRepository = new Mock<ISearchRepository>();
var mockResources = new Mock<IResources>();
var saveSearchForm = new SaveSearchForm(mockSearchRepository.Object, mockResources.Object);
var saveSearchForm = CreateSaveSearchForm(mockSearchRepository);

var searchString = "repo:microsoft/terminal repo:microsoft/PowerToys repo:microsoft/vscode is:open is:issue";
var search = new SearchCandidate(searchString, "Test Search");
Expand Down
Loading