Skip to content

[Draft] Rewrite output parameters #5249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[Draft] Rewrite output parameters #5249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
832d4de
[Draft] Rewrite output parameters
llvm-beanz May 30, 2023
25ed34a
[SPIR-V] Fix pointer array decay
llvm-beanz Jun 16, 2023
caa2695
Need to get non-reference types
llvm-beanz Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions include/dxc/HLSL/DxilGenerationPass.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,6 @@ void initializeCleanupDxBreakPass(llvm::PassRegistry&);
FunctionPass *createDxilLoopDeletionPass(bool NoSink);
void initializeDxilLoopDeletionPass(llvm::PassRegistry &);

ModulePass *createHLLegalizeParameter();
void initializeHLLegalizeParameterPass(llvm::PassRegistry &);

bool AreDxilResourcesDense(llvm::Module *M, hlsl::DxilResourceBase **ppNonDense);

ModulePass *createDxilNoOptLegalizePass();
Expand Down
1 change: 0 additions & 1 deletion lib/HLSL/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ add_llvm_library(LLVMHLSL
DxcOptimizer.cpp
HLDeadFunctionElimination.cpp
HLExpandStoreIntrinsics.cpp
HLLegalizeParameter.cpp
HLLowerUDT.cpp
HLMatrixBitcastLowerPass.cpp
HLMatrixLowerPass.cpp
Expand Down
326 changes: 0 additions & 326 deletions lib/HLSL/HLLegalizeParameter.cpp
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions lib/Transforms/IPO/PassManagerBuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,6 @@ void PassManagerBuilder::populateModulePassManager(
if (HLSLEnableDebugNops) MPM.add(createDxilInsertPreservesPass(HLSLAllowPreserveValues)); // HLSL Change - insert preserve instructions

if (Inliner) {
MPM.add(createHLLegalizeParameter()); // HLSL Change - legalize parameters
// before inline.
MPM.add(Inliner);
Inliner = nullptr;
}
Expand Down Expand Up @@ -404,7 +402,6 @@ void PassManagerBuilder::populateModulePassManager(

MPM.add(createDxilRewriteOutputArgDebugInfoPass()); // Fix output argument types.

MPM.add(createHLLegalizeParameter()); // legalize parameters before inline.
if (HLSLEarlyInlining && Inliner) {
MPM.add(Inliner);
Inliner = nullptr;
Expand Down
Loading