Add a test target to run exec tests with latest warp from nuget #7101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
alsepkow
changed the title
bob80905
reviewed
Jan 30, 2025
damyanp
reviewed
Jan 31, 2025
bob80905
approved these changes
Jan 31, 2025
alsepkow
added a commit
to alsepkow/DirectXShaderCompiler
that referenced
this pull request
Feb 1, 2025
…osoft#7101) **Overview:** This PR resolves microsoft#6505. It adds a cmake file with logic to install nuget packages. It was specifically added so the exec tests could install the latest d3d warp nuget, ensuring the latest shader model support we have. Additionally, the nuget install logic has the ability to install the latest prerelese d3d warp nuget. Selection of the prerelease vs release is toggled using an environment variable. This new logic is accessible by using a new test target 'check-clang-taef-exec-warp'. Alternatively, you can use the the hctbuild script and 'hcttest exec-warp' or 'hcttest exec-warp-preview' **How Tested:** 1. Validated locally with a fresh clean clone, build, and test run. Used 'hctbuild' and 'hcttest exec-warp'. I was unable to directly validate the prerelease path as there is no true prerelease d3d warp nuget available at this time. But I did manually confirm the nuget query on another nuget package which does have a prerelease right now and the query works as expected. 2. Validating end-to-end in the ADO pipeline through this PR.
alsepkow
added a commit
that referenced
this pull request
Feb 1, 2025
…o 1.8.2502) (#7110) Cherry-pick of #7101 to release-1.8.2502 Add a test target to run exec tests with latest warp from nuget **Overview:** This PR resolves #6505. It adds a cmake file with logic to install nuget packages. It was specifically added so the exec tests could install the latest d3d warp nuget, ensuring the latest shader model support we have. Additionally, the nuget install logic has the ability to install the latest prerelese d3d warp nuget. Selection of the prerelease vs release is toggled using an environment variable. This new logic is accessible by using a new test target 'check-clang-taef-exec-warp'. Alternatively, you can use the the hctbuild script and 'hcttest exec-warp' or 'hcttest exec-warp-preview' **How Tested:** 1. Validated locally with a fresh clean clone, build, and test run. Used 'hctbuild' and 'hcttest exec-warp'. I was unable to directly validate the prerelease path as there is no true prerelease d3d warp nuget available at this time. But I did manually confirm the nuget query on another nuget package which does have a prerelease right now and the query works as expected. 2. Validating end-to-end in the ADO pipeline through this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This PR resolves #6505. It adds a cmake file with logic to install nuget packages. It was specifically added so the exec tests could install the latest d3d warp nuget, ensuring the latest shader model support we have. Additionally, the nuget install logic has the ability to install the latest prerelese d3d warp nuget. Selection of the prerelease vs release is toggled using an environment variable. This new logic is accessible by using a new test target 'check-clang-taef-exec-warp'. Alternatively, you can use the the hctbuild script and 'hcttest exec-warp' or 'hcttest exec-warp-preview'
How Tested:
Validated locally with a fresh clean clone, build, and test run. Used 'hctbuild' and 'hcttest exec-warp'. I was unable to directly validate the prerelease path as there is no true prerelease d3d warp nuget available at this time. But I did manually confirm the nuget query on another nuget package which does have a prerelease right now and the query works as expected.
Validating end-to-end in the ADO pipeline through this PR.