-
Notifications
You must be signed in to change notification settings - Fork 546
improvement(api-markdown-documenter): Make uriRoot
parameter optional
#23634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement(api-markdown-documenter): Make uriRoot
parameter optional
#23634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- tools/api-markdown-documenter/api-report/api-markdown-documenter.beta.api.md: Evaluated as low risk
- tools/api-markdown-documenter/api-report/api-markdown-documenter.alpha.api.md: Evaluated as low risk
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thing, otherwise LGTM.
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
The
uriRoot
parameter is an option for changing the root path for all generated links. A sensible default for this parameter is nothing (i.e.""
). This PR makes the parameter optional, and simplifies a couple of test cases by omitting that value.