Skip to content

test(client-presence): future message compat tests #24742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(client-presence): future message compat tests #24742

wants to merge 1 commit into from

Conversation

jason-ha
Copy link
Contributor

added tests:

  • Presence
    • protocol handling
      • receiving unrecognized message
        • ✔ that is NOT optional, throws
        • ✔ that is optional, ignores message and does NOT throw

@jason-ha
test(client-presence): future message compat tests
23b3b25 
added tests:
 - Presence
   - protocol handling
     - receiving unrecognized message
       - ✔ that is NOT optional, throws
       - ✔ that is optional, ignores message and does NOT throw
Copilot
Copilot AI reviewed May 30, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds tests to verify proper handling of unrecognized protocol messages in the presence manager.

  • Introduces a test suite for processing unrecognized messages with two cases: one where a non-optional message correctly throws and one where an optional message is ignored.
  • Implements helper functions to simulate unverified inbound extension messages during tests.

@github-actions github-actions bot added area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch labels May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@tylerbutler tylerbutler Awaiting requested review from tylerbutler

@WillieHabi WillieHabi Awaiting requested review from WillieHabi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jason-ha