Update Hosts & Loaders + Fix Image issue #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
tylerbutler
added
area: host
tylerbutler
reviewed
Aug 18, 2020
| @@ -20,7 +20,7 @@ Objects can have state, which is managed by Distributed Data Structures (DDSes). | |||
| DDSes are used to distribute state to clients. Instead of centralizing merge logic in the | |||
| server, the server passes changes (aka operations or ops) to clients and the clients perform the merge. | |||
|
|
|||
|  | |||
|  | |||
There was a problem hiding this comment.
I fixed this in commit acd818e. I'd like to keep the images alongside the article they're referenced in, which we can do using Page Bundles.
There was a problem hiding this comment.
I didn't notice that you were reusing the images in multiple articles. We may need something better long term but this is OK for now.
This reverts commit 687f0a7ffb89f1e77c06eb684999114088192cf0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took an opinionated approach on image storage based on this issue (gohugoio/hugo#1240)
Looking for feedback on the docs besides this.