Skip to content

Add root property jsonSchemaDialect #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Mar 7, 2023

Conversation

MaggieKimani1
Copy link
Contributor

This PR:

  • Adds a root property jsonSchemaDialect field and logic to serialize and deserialize
  • Updates the SerializeAsV3() method by adding an optional OpenApiSpecVersion parameter in order to write out version-specific properties
  • Adds a test for validation and refactors/cleans up existing tests

@MaggieKimani1 MaggieKimani1 self-assigned this Feb 1, 2023
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates. The only remaining thing is this comment I had left earlier.
#1138 (comment)

Also, I'm not asking you to change that, but you could have simply passed callback instead of (w, o) => callback(w, o) in a lot of places. Saying that for future references for you :)

@MaggieKimani1
Copy link
Contributor Author

Thanks for making these updates. The only remaining thing is this comment I had left earlier. #1138 (comment)

Also, I'm not asking you to change that, but you could have simply passed callback instead of (w, o) => callback(w, o) in a lot of places. Saying that for future references for you :)

Yes, I'm working on that too. I have tests failing locally due to writer scope issues when writing start and end objects with all the serialization refactoring I've implemented. I want to fix these as well and the PR will be good to go.
Also, thanks for the pointer above.

@MaggieKimani1 MaggieKimani1 merged commit 76effe4 into release/2.0.0 Mar 7, 2023
@MaggieKimani1 MaggieKimani1 deleted the mk/add-json-schema-dialect branch March 7, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants