-
Notifications
You must be signed in to change notification settings - Fork 253
Add root property jsonSchemaDialect #1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…sion for serialiazing/deserializing properties only available in v3.1
…ut version-specific properties
src/Microsoft.OpenApi/Extensions/OpenApiSerializableExtensions.cs
Outdated
Show resolved
Hide resolved
…3.1 without reference and clean up tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these updates. The only remaining thing is this comment I had left earlier.
#1138 (comment)
Also, I'm not asking you to change that, but you could have simply passed callback
instead of (w, o) => callback(w, o)
in a lot of places. Saying that for future references for you :)
Yes, I'm working on that too. I have tests failing locally due to writer scope issues when writing start and end objects with all the serialization refactoring I've implemented. I want to fix these as well and the PR will be good to go. |
This PR:
jsonSchemaDialect
field and logic to serialize and deserializeSerializeAsV3()
method by adding an optionalOpenApiSpecVersion
parameter in order to write out version-specific properties