Skip to content

Lint deploy/ scripts #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 2, 2021
Merged

Lint deploy/ scripts #1085

merged 4 commits into from
Aug 2, 2021

Conversation

saschanaz
Copy link
Contributor

This changes .mjs to .js because

  • jsconfig does not support .mjs
  • they don't need to be .mjs because there is "type": "module" in package.json already.

@orta
Copy link
Contributor

orta commented Aug 2, 2021

Looks good, I can't merge due to conflicts from #1084 though 👍🏻

@saschanaz
Copy link
Contributor Author

#1084 broke the deploy action because of octokit version, this should fix it.

@orta
Copy link
Contributor

orta commented Aug 2, 2021

Ace

@orta orta merged commit b85127a into microsoft:main Aug 2, 2021
@saschanaz saschanaz deleted the lint-deploy branch August 2, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants