Skip to content

Make ChildNode and ParentNode extend Node again #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 3, 2021
Merged

Make ChildNode and ParentNode extend Node again #1088

merged 5 commits into from
Aug 3, 2021
+20 −14

Conversation

DanielRosenwasser
Copy link
Member

Fixes #1087

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2021

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@DanielRosenwasser
Copy link
Member Author

CC @saschanaz

@DanielRosenwasser DanielRosenwasser requested a review from orta August 3, 2021 00:53
@DanielRosenwasser DanielRosenwasser mentioned this pull request Aug 3, 2021
Merged
@saschanaz
Copy link
Contributor

LGTM

@github-actions github-actions bot merged commit 0b7c8ce into main Aug 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2021

Merging because @saschanaz is a code-owner of all the changes - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschanaz saschanaz saschanaz left review comments

@orta orta Awaiting requested review from orta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ChildNode/ParentNode no longer extending Node
2 participants
@DanielRosenwasser @saschanaz